-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Rename Ports fields in status #1938
🌱 Rename Ports fields in status #1938
Conversation
The json field names were unnecessarily leaking the internal name of a struct.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
|
||
// portsOpts is the list of ports options to create for the machine. | ||
// Ports is the fully resolved list of ports to create for the machine. | ||
// +optional | ||
PortsOpts []PortOpts `json:"portsOpts,omitempty"` | ||
Ports []PortOpts `json:"ports,omitempty"` | ||
} | ||
|
||
type DependentMachineResources struct { | ||
// PortsStatus is the status of the ports created for the machine. | ||
// Ports is the status of the ports created for the machine. | ||
// +optional | ||
PortsStatus []PortStatus `json:"portsStatus,omitempty"` | ||
Ports []PortStatus `json:"ports,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it should have documentation entry added?
The json field names were unnecessarily leaking the internal name of a struct.